[PATCH] D71591: [llvm-readob] - Refactor printing of sections flags. NFCI.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1455
 static const EnumEntry<unsigned> ElfARMSectionFlags[] = {
-  LLVM_READOBJ_ENUM_ENT(ELF, SHF_ARM_PURECODE)
+  ENUM_ENT(SHF_ARM_PURECODE, "y")
 };
----------------
jhenderson wrote:
> Honestly, it seems a little weird to have this inconsistency in the different macros. As far as I can see, the only difference is to provide an AltName field, right? Would it be a good idea to change all the other flags to use `ENUM_ENT`, perhaps with an empty AltName?
> 
> This would also help ensure that people consider what, if any, GNU flag letter a new flag should have, and would also allow us to avoid the situation where some flags for a target might have a GNU representation, but not others.
OK.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71591/new/

https://reviews.llvm.org/D71591