[PATCH] D71473: [Alignment][NFC] Deprecate untyped variants of CreateMemCpy/CreateMemMove

[Guillaume Chatelet via llvm-commits]

This is unexpected, I've fixed all in-tree caller sites so it doesn't
trigger the warning. Can you give me the failing call sites please ?
Meanwhile I'll revert the commit.

On Mon, Dec 16, 2019 at 3:08 PM Aaron Ballman <aaron at aaronballman.com>
wrote:

> This change is now triggering hundreds (700+) of warnings in Visual
> Studio and makes it impossible to have a -Werror build. Can this be
> fixed or reverted?
>
> C:\llvm-project\llvm\include\llvm\IR\IRBuilder.h(575): warning C4996:
> 'llvm::IRBuilderBase::CreateMemMove': Use the version that takes
> MaybeAlign
>   C:\llvm-project\llvm\include\llvm/IR/IRBuilder.h(588): note: see
> declaration of 'llvm::IRBuilderBase::CreateMemMove'
>
> ~Aaron
>
> On Mon, Dec 16, 2019 at 7:38 AM Guillaume Chatelet via Phabricator via
> llvm-commits <llvm-commits at lists.llvm.org> wrote:
> >
> > This revision was automatically updated to reflect the committed changes.
> > Closed by commit rG181ab91efc9f: [Alignment][NFC] Deprecate
> CreateMemCpy/CreateMemMove (authored by gchatelet).
> >
> > Repository:
> >   rG LLVM Github Monorepo
> >
> > CHANGES SINCE LAST ACTION
> >   https://reviews.llvm.org/D71473/new/
> >
> > https://reviews.llvm.org/D71473
> >
> > Files:
> >   llvm/include/llvm/IR/Argument.h
> >   llvm/include/llvm/IR/Function.h
> >   llvm/include/llvm/IR/IRBuilder.h
> >   llvm/include/llvm/IR/InstrTypes.h
> >   llvm/include/llvm/IR/Instructions.h
> >   llvm/include/llvm/IR/IntrinsicInst.h
> >   llvm/lib/CodeGen/SafeStack.cpp
> >   llvm/lib/IR/Core.cpp
> >   llvm/lib/IR/Function.cpp
> >   llvm/lib/IR/Instructions.cpp
> >   llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp
> >   llvm/lib/Target/Hexagon/HexagonLoopIdiomRecognition.cpp
> >   llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
> >   llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
> >   llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp
> >   llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp
> >   llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp
> >   llvm/lib/Transforms/Utils/InlineFunction.cpp
> >   llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191216/785c1b1e/attachment.html>