<div dir="ltr">This is unexpected, I've fixed all in-tree caller sites so it doesn't trigger the warning. Can you give me the failing call sites please ?<div></div><div>Meanwhile I'll revert the commit.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Dec 16, 2019 at 3:08 PM Aaron Ballman <<a href="mailto:aaron@aaronballman.com">aaron@aaronballman.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">This change is now triggering hundreds (700+) of warnings in Visual<br>
Studio and makes it impossible to have a -Werror build. Can this be<br>
fixed or reverted?<br>
<br>
C:\llvm-project\llvm\include\llvm\IR\IRBuilder.h(575): warning C4996:<br>
'llvm::IRBuilderBase::CreateMemMove': Use the version that takes<br>
MaybeAlign<br>
  C:\llvm-project\llvm\include\llvm/IR/IRBuilder.h(588): note: see<br>
declaration of 'llvm::IRBuilderBase::CreateMemMove'<br>
<br>
~Aaron<br>
<br>
On Mon, Dec 16, 2019 at 7:38 AM Guillaume Chatelet via Phabricator via<br>
llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> This revision was automatically updated to reflect the committed changes.<br>
> Closed by commit rG181ab91efc9f: [Alignment][NFC] Deprecate CreateMemCpy/CreateMemMove (authored by gchatelet).<br>
><br>
> Repository:<br>
>   rG LLVM Github Monorepo<br>
><br>
> CHANGES SINCE LAST ACTION<br>
>   <a href="https://reviews.llvm.org/D71473/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D71473/new/</a><br>
><br>
> <a href="https://reviews.llvm.org/D71473" rel="noreferrer" target="_blank">https://reviews.llvm.org/D71473</a><br>
><br>
> Files:<br>
>   llvm/include/llvm/IR/Argument.h<br>
>   llvm/include/llvm/IR/Function.h<br>
>   llvm/include/llvm/IR/IRBuilder.h<br>
>   llvm/include/llvm/IR/InstrTypes.h<br>
>   llvm/include/llvm/IR/Instructions.h<br>
>   llvm/include/llvm/IR/IntrinsicInst.h<br>
>   llvm/lib/CodeGen/SafeStack.cpp<br>
>   llvm/lib/IR/Core.cpp<br>
>   llvm/lib/IR/Function.cpp<br>
>   llvm/lib/IR/Instructions.cpp<br>
>   llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp<br>
>   llvm/lib/Target/Hexagon/HexagonLoopIdiomRecognition.cpp<br>
>   llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp<br>
>   llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp<br>
>   llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp<br>
>   llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp<br>
>   llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp<br>
>   llvm/lib/Transforms/Utils/InlineFunction.cpp<br>
>   llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp<br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>