[PATCH] D71484: [WebAssembly][InstrEmitter] Foundation for multivalue call lowering

Fri Dec 13 15:45:37 PST 2019

tlively marked an inline comment as done.
tlively added a comment.

In D71484#1783994 <https://reviews.llvm.org/D71484#1783994>, @sbc100 wrote:

> In the description you say " .. unique among upstream targets", and later "... WebAssembly and similar downstream targets.".     Was it deliberate to use both "upstream" and "downstream", what do these term mean here?  Also the "unique" statement seems to contract the "and similar" statement.

Yes, this was deliberate. Upstream targets are targets in the LLVM source tree, and downstream targets are targets that people add to LLVM without checking them into the main repo. An example of a downstream target that is similar to WebAssembly is the TVM architecture for the TON blockchain network.

================
Comment at: llvm/test/CodeGen/WebAssembly/multivalue.ll:2
+; RUN: llc < %s -asm-verbose=false -verify-machineinstrs -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers -mattr=+multivalue,+tail-call | FileCheck %s
+; RUN: llc < %s --filetype=obj -mattr=+multivalue,+tail-call | obj2yaml | FileCheck %s --check-prefix OBJ

----------------
sbc100 wrote:
> Is this test also now testing tail call somehow?
Yes, one of the new tests below has a musttail call, which errors out if `tail-call` is not enabled.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71484/new/

https://reviews.llvm.org/D71484