[PATCH] D71484: [WebAssembly][InstrEmitter] Foundation for multivalue call lowering

Fri Dec 13 11:28:23 PST 2019

sbc100 added a comment.

In the description you say " .. unique among upstream targets", and later "... WebAssembly and similar downstream targets.".     Was it deliberate to use both "upstream" and "downstream", what do these term mean here?  Also the "unique" statement seems to contract the "and similar" statement.

================
Comment at: llvm/test/CodeGen/WebAssembly/multivalue.ll:2
+; RUN: llc < %s -asm-verbose=false -verify-machineinstrs -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers -mattr=+multivalue,+tail-call | FileCheck %s
+; RUN: llc < %s --filetype=obj -mattr=+multivalue,+tail-call | obj2yaml | FileCheck %s --check-prefix OBJ

----------------
Is this test also now testing tail call somehow?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71484/new/

https://reviews.llvm.org/D71484