[PATCH] D71470: Recommit "[ARM][MVE] findVCMPToFoldIntoVPS"

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 13 09:38:16 PST 2019


SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Target/ARM/MVEVPTBlockPass.cpp:239
       MIBuilder.add(VCMP->getOperand(3));
       VCMP->eraseFromParent();
     } else {
----------------
Actually, I was planning on making one more change: save all the instructions that we want to remove to a worklist, so that they can all be removed in one go at the end. This should avoid that RDA possibly has an inconsistent view on the block...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71470/new/

https://reviews.llvm.org/D71470





More information about the llvm-commits mailing list