[PATCH] D71470: Recommit "[ARM][MVE] findVCMPToFoldIntoVPS"

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer created this revision.
SjoerdMeijer added reviewers: samparker, dmgreen.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a project: LLVM.

This is a recommit of D71330 <https://reviews.llvm.org/D71330>, but with a few things fixed/changed:

- ReachingDefAnalysis: this was not running with optnone as it was checking `skipFunction()`, which other analysis passes don't do. I guess this is a copy-paste from a codegen pass.
- VPTBlockPass: here I've added skipFunction(), because like most/all optimisations, we don't want to run this with optnone.

This fixes the issues with the initial/previous commit of this: the VPTBlockPass was running with optnone, but ReachingDefAnalysis wasn't, and so VPTBlockPass was crashing querying ReachingDefAnalysis.

      

I've added test case mve-vpt-block-optnone.mir to check that we don't run VPTBlock with optnone.


https://reviews.llvm.org/D71470

Files:
  llvm/lib/CodeGen/ReachingDefAnalysis.cpp
  llvm/lib/Target/ARM/MVEVPTBlockPass.cpp
  llvm/test/CodeGen/ARM/O3-pipeline.ll
  llvm/test/CodeGen/Thumb2/mve-vpt-block-optnone.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71470.233809.patch
Type: text/x-patch
Size: 8757 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191213/69040c11/attachment.bin>