[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added a comment.

In D71213#1783467 <https://reviews.llvm.org/D71213#1783467>, @nhaehnle wrote:

> In D71213#1781322 <https://reviews.llvm.org/D71213#1781322>, @gchatelet wrote:
>
> > LLVM has this `LLVM_ATTRIBUTE_DEPRECATED` macro, it's convenient to get a warning but it only works when building without `-Wall`.
>
>
> Did you mean to write _with_ -Wall? I fail to see anything that stops the macro from working with -Wall?
>
> Generally, I'd say using that macro a bit more for this kind of thing would be a good idea.


Sorry I meant `-Werror` which will turn warnings into errors, then deprecation messages will break compilation.
I thought it was ON by default but it's not the case <https://github.com/llvm/llvm-project/blob/dc9e6ba90bebe72f846e76fcc3f2c5145df24613/llvm/CMakeLists.txt#L400>.
I'll go this route then. Thx!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71213/new/

https://reviews.llvm.org/D71213