[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 13 05:58:18 PST 2019


nhaehnle added a comment.

In D71213#1781322 <https://reviews.llvm.org/D71213#1781322>, @gchatelet wrote:

> LLVM has this `LLVM_ATTRIBUTE_DEPRECATED` macro, it's convenient to get a warning but it only works when building without `-Wall`.


Did you mean to write _with_ -Wall? I fail to see anything that stops the macro from working with -Wall?

Generally, I'd say using that macro a bit more for this kind of thing would be a good idea.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71213/new/

https://reviews.llvm.org/D71213





More information about the llvm-commits mailing list