[PATCH] D71401: [AArch64][SVE] Add permutation and selection intrinsics

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 13 05:49:11 PST 2019


sdesmalen added a subscriber: kmclaughlin.
sdesmalen added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:782
                  LLVMMatchType<0>,
                  llvm_i32_ty],
                 [IntrNoMem]>;
----------------
c-rhodes wrote:
> efriedma wrote:
> > I guess this is sort of orthogonal to your patch, but this is missing ImmArg marking
> Using `ImmArg` for this class opens up a can of worms, I know Kerry ran into similar issues in a separate patch. From what I understand it requires using `TImmLeaf` instead of `ImmLeaf` for the imm args in instruction definitions and some of those operands are used all over the AArch64 backend.
@kmclaughlin is currently looking into a fix for the ImmArg issue for these intrinsics (introduced by D69707 and D70253).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71401/new/

https://reviews.llvm.org/D71401





More information about the llvm-commits mailing list