[PATCH] D71394: llvm-objdump should ignore Mach-O stab symbols for disassembly.
Michael Trent via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 12 07:45:30 PST 2019
mtrent marked 2 inline comments as done.
mtrent added inline comments.
================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1831
+ // section, because a STAB section might not actually be a section.
+ bool isSTAB = false;
+ if (O->isMachO()) {
----------------
MaskRay wrote:
> MaskRay wrote:
> > Move the variable inside `if`.
> >
> > Can you lift `MachO` below outside the loop?
> Please ignore `Move the variable inside if.`
Ignoring the variable, is it still desirable to make the MachO available in to the entire function?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71394/new/
https://reviews.llvm.org/D71394
More information about the llvm-commits
mailing list