[PATCH] D71394: llvm-objdump should ignore Mach-O stab symbols for disassembly.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 11 23:12:03 PST 2019


MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1831
+    // section, because a STAB section might not actually be a section. 
+    bool isSTAB = false;
+    if (O->isMachO()) {
----------------
Move the variable inside `if`.

Can you lift `MachO` below outside the loop?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71394/new/

https://reviews.llvm.org/D71394





More information about the llvm-commits mailing list