[PATCH] D71418: [llvm-readobj] - Fix letters used for dumping section types in GNU style.

[George Rimar via Phabricator via llvm-commits]

grimar marked 2 inline comments as done.
grimar added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1447-1448
+  ENUM_ENT(SHF_EXCLUDE,          "E"),
   ENUM_ENT(SHF_MASKOS,           "o"),
   ENUM_ENT(SHF_MASKPROC,         "p"),
 };
----------------
jhenderson wrote:
> Should we test these two too? It looks like there's no testing here, but GNU supposedly prints them (I have not verified that this is the case).
It is similar to
https://reviews.llvm.org/D71333#inline-644830
(i.e. this follow-up for D71333 is in my TODO list and waits for D71411 that have be landed first)

(I actually working on follow-ups we discussed, and made this patch because plan to
remove these 2 from this array (because they are masks).)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71418/new/

https://reviews.llvm.org/D71418