[PATCH] D71418: [llvm-readobj] - Fix letters used for dumping section types in GNU style.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/section-flags.test:74
+# LLVM-NEXT: Flags [ (0x100)
+# LLVM-NEXT:   SHF_OS_NONCONFORMING (0x1
+# LLVM-NEXT: ]
----------------
Nit: `(0x100)`


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1447-1448
+  ENUM_ENT(SHF_EXCLUDE,          "E"),
   ENUM_ENT(SHF_MASKOS,           "o"),
   ENUM_ENT(SHF_MASKPROC,         "p"),
 };
----------------
Should we test these two too? It looks like there's no testing here, but GNU supposedly prints them (I have not verified that this is the case).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71418/new/

https://reviews.llvm.org/D71418