[PATCH] D71333: [llvm-readobj][test] - Add a test for testing regular section flags and cleanup flags testing.

[George Rimar via Phabricator via llvm-commits]

grimar marked 3 inline comments as done.
grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/section-arch-flags.test:33
+# MIPS-LLVM:      Flags [ (0xFF000000)
+# MIPS-LLVM-NEXT:   SHF_EXCLUDE (0x80000000)
+## FIXME: we should not print SHF_MASKPROC, because it is a mask value.
----------------
jhenderson wrote:
> jhenderson wrote:
> > Do you think we should avoid printing SHF_EXCLUDE for MIPS, since it clashes?
> Never mind, you posted your comments as I was writing mine. It probably should be up to a MIPS developer to discuss this point.
Yeah, sorry, I've pushed it a minute later that the patch itself.

Answering this question I actually kind of confused why they used the similar
value. It's indeed up to them what to do with it.. Perhaps leaving it alone is not so
bad for the code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71333/new/

https://reviews.llvm.org/D71333