[PATCH] D71333: [llvm-readobj][test] - Add a test for testing regular section flags and cleanup flags testing.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 12 02:53:09 PST 2019
jhenderson added inline comments.
================
Comment at: llvm/test/tools/llvm-readobj/ELF/section-arch-flags.test:33
+# MIPS-LLVM: Flags [ (0xFF000000)
+# MIPS-LLVM-NEXT: SHF_EXCLUDE (0x80000000)
+## FIXME: we should not print SHF_MASKPROC, because it is a mask value.
----------------
jhenderson wrote:
> Do you think we should avoid printing SHF_EXCLUDE for MIPS, since it clashes?
Never mind, you posted your comments as I was writing mine. It probably should be up to a MIPS developer to discuss this point.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71333/new/
https://reviews.llvm.org/D71333
More information about the llvm-commits
mailing list