[PATCH] D71269: [llvm-readobj][test] - Cleanup and split tests in tools/llvm-readobj folder.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 12 00:25:20 PST 2019
grimar marked 3 inline comments as done.
grimar added inline comments.
================
Comment at: llvm/test/tools/llvm-readobj/COFF/symbols.test:1
+## Test how do we print symbols.
+
----------------
jhenderson wrote:
> jhenderson wrote:
> > Delete "do"
> Ping? This got missed.
Sorry!
================
Comment at: llvm/test/tools/llvm-readobj/MachO/sections-ext.test:14
+
+# RUN: llvm-readobj --expand-relocs -S --section-symbols --section-relocations --section-data \
+# RUN: %p/Inputs/trivial.obj.macho-ppc | FileCheck %s --check-prefix MACHO-PPC
----------------
MaskRay wrote:
> Optional: maybe we can delete --expand-relocs to make the tests less verbose. Some llvm-readobj commands above do not use this option.
It comes from the original test. I'd do any functional changes/improvements separatelly.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71269/new/
https://reviews.llvm.org/D71269
More information about the llvm-commits
mailing list