[PATCH] D71269: [llvm-readobj][test] - Cleanup and split tests in tools/llvm-readobj folder.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 11 21:14:16 PST 2019


MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/MachO/sections-ext.test:14
+
+# RUN: llvm-readobj --expand-relocs -S --section-symbols --section-relocations --section-data \
+# RUN:  %p/Inputs/trivial.obj.macho-ppc | FileCheck %s --check-prefix MACHO-PPC
----------------
Optional: maybe we can delete --expand-relocs to make the tests less verbose. Some llvm-readobj commands above do not use this option.


================
Comment at: llvm/test/tools/llvm-readobj/archive.test:83
+  Characteristics: [  ]
+sections:
+symbols:
----------------
`sections: []`


================
Comment at: llvm/test/tools/llvm-readobj/basic.test:1
 # Test case where input file does not exit.
+RUN: not llvm-readobj %t.blah 2>&1 | FileCheck --check-prefix=ENOENT -DTOOL=readobj %s
----------------
`##`


================
Comment at: llvm/test/tools/llvm-readobj/thin-archive.test:86
+  Characteristics: [  ]
+sections:
+symbols:
----------------
`sections: []`
`symbols: []`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71269/new/

https://reviews.llvm.org/D71269





More information about the llvm-commits mailing list