[PATCH] D70756: llvm-symbolizer: support DW_FORM_loclistx locations.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-symbolizer/frame-loclistx.s:1
+// Test dwarf-5 DW_AT_location [DW_FORM_loclistx].
+// REQUIRES: aarch64-registered-target
----------------
I think this test would make more sense in the DebugInfo test directory, as this isn't really testing llvm-symbolizer's specific features, and is more testing the DebugInfo library code.

A couple of other points:
* I've noticed that a number of text editors don't work well with C++ style comments for .s files. I think you should use '#' (and '##' for comments to improve clarity of comments versus lit/FileCheck directives).
* The assembly is very complex. Can you reduce it down significantly to just what you need for your test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70756/new/

https://reviews.llvm.org/D70756