[PATCH] D70756: llvm-symbolizer: support DW_FORM_loclistx locations.

Oliver Stannard (Linaro) via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 10 02:59:43 PST 2019


ostannard added inline comments.
Herald added a reviewer: jhenderson.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDie.cpp:503
+      if (auto LoclistOffset = U->getLoclistOffset(Offset))
+        Offset = *LoclistOffset + getDwarfUnit()->getLocSectionBase();
+      else
----------------
It looks like this patch conflicts with D71006, which adds the loc section base inside DWARFUnit::getLoclistOffset, so it doesn't need adding here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70756/new/

https://reviews.llvm.org/D70756





More information about the llvm-commits mailing list