[PATCH] D71158: [NFC][InstSimplify] Refactoring ThreadCmpOverSelect function

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 9 16:11:32 PST 2019


xbolva00 added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:158
+/// Simplify comparison with true branch of select
+static Value *simplifyCmpSelTrueCase(CmpInst::Predicate Pred, Value *LHS,
+                                     Value *RHS, Value *Cond,
----------------
btw, do you plan to use this helper functions in a future patch? For now, I dont think we really need them in this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71158/new/

https://reviews.llvm.org/D71158





More information about the llvm-commits mailing list