[PATCH] D71158: [NFC][InstSimplify] Refactoring ThreadCmpOverSelect function

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 9 16:11:31 PST 2019


xbolva00 added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:156
+  }
+  return SimplifiedCmp;
+}
----------------
xbolva00 wrote:
> dendibakh wrote:
> > xbolva00 wrote:
> > > return nullptr;
> > Here `SimplifiedCmp` should stay, because composed comparison can be simplified to something other than true or false, so we should return it.
> Oh, okay :)
(maybe you can add a code comment too)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71158/new/

https://reviews.llvm.org/D71158





More information about the llvm-commits mailing list