[PATCH] D69571: [ValueTracking] Allow context-sensitive nullness check for non-pointers

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 8 20:18:59 PST 2019


jdoerfert abandoned this revision.
jdoerfert added a comment.

@nikic Thanks for reopening this, I did not see the problem at all!

Same thing as last time. When we recurse through PHI nodes we need to update the context instruction or we get information for the wrong place. This time I fixed it in computeKnownBits.

I created D71181 <https://reviews.llvm.org/D71181> with the proper fixes and additional test case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69571/new/

https://reviews.llvm.org/D69571





More information about the llvm-commits mailing list