[PATCH] D71009: [AArch64][SVE] Add wide compare immediate patterns

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 6 17:11:50 PST 2019


efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:10554
+
+        if (ImmVal >= -16 && ImmVal <= 15) {
+          SDValue Imm = DAG.getConstant(ImmVal, DL, MVT::i32);
----------------
Can you refactor this so there isn't a bunch of copy-pasted code for signed vs. unsigned?  The only relevant difference between the two codepaths is the preferred check for "Imm".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71009/new/

https://reviews.llvm.org/D71009





More information about the llvm-commits mailing list