[PATCH] D71009: [AArch64][SVE] Add wide compare immediate patterns

Thu Dec 5 10:05:33 PST 2019

c-rhodes marked 2 inline comments as done.
c-rhodes added inline comments.

================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:10507
+  if (Comparator.getOpcode() == AArch64ISD::DUP ||
+      Comparator.getOpcode() == ISD::SPLAT_VECTOR) {
+    unsigned IID = getIntrinsicID(N);
----------------
efriedma wrote:
> I guess it's sort of orthogonal to this patch, but why do we have two opcodes for the same operation?
`AArch64ISD::DUP` has been around for a while and `SPLAT_VECTOR` was recently introduced by Graham, but he didn't want to remove `DUP` in that patch and it's not been revisited yet.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71009/new/

https://reviews.llvm.org/D71009