[PATCH] D70918: Don't call export_symbols.py with duplicate libs

David Tenty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 6 13:39:09 PST 2019


daltenty updated this revision to Diff 232640.
daltenty added a comment.

- Move the deduplication after the loop, so we also cover the transitive dependencies


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70918/new/

https://reviews.llvm.org/D70918

Files:
  llvm/cmake/modules/AddLLVM.cmake


Index: llvm/cmake/modules/AddLLVM.cmake
===================================================================
--- llvm/cmake/modules/AddLLVM.cmake
+++ llvm/cmake/modules/AddLLVM.cmake
@@ -873,6 +873,7 @@
       set(new_libs ${newer_libs})
       set(newer_libs "")
     endwhile()
+    list(REMOVE_DUPLICATES static_libs)
     if (MSVC)
       set(mangling microsoft)
     else()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70918.232640.patch
Type: text/x-patch
Size: 378 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191206/b2102712/attachment.bin>


More information about the llvm-commits mailing list