[PATCH] D70918: Don't call export_symbols.py with duplicate libs

John Brawn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 5 08:19:05 PST 2019


john.brawn added inline comments.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:854
     set(link_libs ${new_libs})
+    list(REMOVE_DUPLICATES new_libs)
     while(NOT "${new_libs}" STREQUAL "")
----------------
Given that it's the static_libs list that's passed to extract_symbols.py it would make more sense to remove the duplicates from that list (i.e. after the below loop, in case the loop adds duplicates).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70918/new/

https://reviews.llvm.org/D70918





More information about the llvm-commits mailing list