[PATCH] D71109: [ARM] Disable VLD4 under MVE

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:147
+MVEMaxSupportedInterleaveFactor("mve-max-interleave-factor", cl::Hidden,
+  cl::desc("Maximum VLDn for MVE. Defaults to 2"),
+  cl::init(2));
----------------
Nit: not sure we need to say "Defaults" to 2 as I don't see much prior art of mentioning the default value (it would also require to keep the message up to date with the value when that gets changed, although that is of course not a really difficult problem).


================
Comment at: llvm/test/Transforms/LoopVectorize/ARM/mve-vldn.ll:4
+; RUN: opt -loop-vectorize -mve-max-interleave-factor=2 < %s -S -o - | FileCheck %s --check-prefixes=CHECK,CHECK-2,CHECK-NO4
+; RUN: opt -loop-vectorize -mve-max-interleave-factor=4 < %s -S -o - | FileCheck %s --check-prefixes=CHECK,CHECK-2,CHECK-4
+
----------------
Perhaps silly question, but what happens when we pass `-mve-max-interleave-factor=42`, i.e. a value > 4? Is input checked? Do we need to mention that acceptable values are 1, 2, and 4?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71109/new/

https://reviews.llvm.org/D71109