[PATCH] D70750: [AutoFDO] Inline replay for cold/small callees from sample profile loader

[Wei Mi via Phabricator via llvm-commits]

wmi added a comment.

Did performance test and I saw 0.4% improvement in an internal benchmark. That is a good improvement, thanks for the change!



================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:965
       }
-      if (Hot) {
-        CIS.insert(CIS.begin(), Candidates.begin(), Candidates.end());
+      if (Hot || ProfileReInlineAll) {
+        CIS.insert(CIS.begin(), AllCandidates.begin(), AllCandidates.end());
----------------
Can we inline all by setting sample-profile-cold-inline-threshold to a very large number so ProfileReInlineAll is not needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70750/new/

https://reviews.llvm.org/D70750