[PATCH] D68717: [Codegen] More add_sat and sub_sat promotion

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 5 08:55:46 PST 2019


nikic added a comment.

In D68717#1763170 <https://reviews.llvm.org/D68717#1763170>, @dmgreen wrote:

> Sorry for the delay. Now that I have added some extra Neon codegen (and some extra tests), this is how this looks.
>
> The unsigned cases still look like a clear win. The signed cases looks worse (although you could argue in cases that this would simplify if part of a loop).
>
> WDYT? Remove the signed part and keep the unsigned?


Yeah, I think we'll want to keep just the unsigned part.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68717/new/

https://reviews.llvm.org/D68717





More information about the llvm-commits mailing list