[PATCH] D68829: [LNT] Python 3 support: Parse HTML as text

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre marked 2 inline comments as done.
thopre added inline comments.


================
Comment at: tests/server/ui/test_api_modify.py:68
         for key in ('hardware', 'os', 'hostname', 'new_parameter', 'uname'):
             self.assertEquals(machine_after.get(key, None),
                               data['machine'].get(key, None))
----------------
PrzemekWirkus wrote:
> Nitpick:
> 
> We indeed tend toward assertEqual for Python 3. 
> You've already replaced one assertEquala with assertEqual in this patch, could you clean this one up as well? 
I've made a separate diff fixing all existing use of assertEquals: https://reviews.llvm.org/D71057


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68829/new/

https://reviews.llvm.org/D68829