[PATCH] D68829: [LNT] Python 3 support: Parse HTML as text
Przemyslaw Wirkus via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 5 03:07:31 PST 2019
PrzemekWirkus added a comment.
LGTM but someone else must approve.
================
Comment at: tests/server/ui/test_api_modify.py:68
for key in ('hardware', 'os', 'hostname', 'new_parameter', 'uname'):
self.assertEquals(machine_after.get(key, None),
data['machine'].get(key, None))
----------------
Nitpick:
We indeed tend toward assertEqual for Python 3.
You've already replaced one assertEquala with assertEqual in this patch, could you clean this one up as well?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68829/new/
https://reviews.llvm.org/D68829
More information about the llvm-commits
mailing list