[PATCH] D70116: [RISCV] add subtargets initialized with target feature

[Kuan Hsu Chen (Zakk) via Phabricator via llvm-commits]

khchen marked 2 inline comments as done.
khchen added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/subtarget-features-std-ext.ll:6
+
+; RV32IF-ILP32F: Hard-float 'f' ABI can't be used for a target that doesn't support the F instruction set extension (ignoring target-abi)
+
----------------
efriedma wrote:
> Not really an issue with this patch specifically, but backends shouldn't be writing directly to stderr.  There's a diagnose() API on LLVMContext.
got it, I will fix it, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70116/new/

https://reviews.llvm.org/D70116