[PATCH] D70116: [RISCV] add subtargets initialized with target feature
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 3 16:19:31 PST 2019
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/test/CodeGen/RISCV/subtarget-features-std-ext.ll:6
+
+; RV32IF-ILP32F: Hard-float 'f' ABI can't be used for a target that doesn't support the F instruction set extension (ignoring target-abi)
+
----------------
Not really an issue with this patch specifically, but backends shouldn't be writing directly to stderr. There's a diagnose() API on LLVMContext.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70116/new/
https://reviews.llvm.org/D70116
More information about the llvm-commits
mailing list