[PATCH] D69178: [DebugInfo] Use DBG_VALUEs IsIndirect field for describing stack spills

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 3 09:37:30 PST 2019


aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:240
       uint64_t RegNo;
       SpillLoc SpillLocation;
       int64_t Immediate;
----------------
It looks like this is exploding the size of the union. Could SpillLocation be made to fit into 64 bits, or does the extra 8 bytes not matter, or should it be an index into a side-table in the union?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69178/new/

https://reviews.llvm.org/D69178





More information about the llvm-commits mailing list