[PATCH] D69178: [DebugInfo] Use DBG_VALUEs IsIndirect field for describing stack spills

[Jeremy Morse via Phabricator via llvm-commits]

jmorse updated this revision to Diff 231884.
jmorse added a comment.
Herald added a subscriber: hiraditya.

Address review comments -- the "hash" fields were for comparing the contents of the Loc union, as it's now too big to be a value type. I've used memset and memcmp in its place now, which should be a bit clearer.

There's an additional change to the test CodeGen/ARM/dbg-range-extension.mir, but it's not interesting (constant-valued DBG_VALUE had isIndirect set). Not sure why this didn't fail before, I probably just forgot to add it to this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69178/new/

https://reviews.llvm.org/D69178

Files:
  llvm/lib/CodeGen/LiveDebugValues.cpp
  llvm/lib/CodeGen/LiveDebugVariables.cpp
  llvm/lib/CodeGen/PrologEpilogInserter.cpp
  llvm/test/CodeGen/ARM/dbg-range-extension.mir
  llvm/test/CodeGen/MIR/X86/diexpr-win32.mir
  llvm/test/CodeGen/X86/prologepilog_deref_size.mir
  llvm/test/DebugInfo/AArch64/compiler-gen-bbs-livedebugvalues.mir
  llvm/test/DebugInfo/COFF/pieces.ll
  llvm/test/DebugInfo/MIR/X86/kill-after-spill.mir
  llvm/test/DebugInfo/MIR/X86/live-debug-values-3preds.mir
  llvm/test/DebugInfo/MIR/X86/live-debug-values-restore-collide.mir
  llvm/test/DebugInfo/MIR/X86/live-debug-values-restore.mir
  llvm/test/DebugInfo/MIR/X86/live-debug-values-spill.mir
  llvm/test/DebugInfo/MIR/X86/live-debug-values-stack-clobber.mir
  llvm/test/DebugInfo/MIR/X86/prolog-epilog-indirection.mir
  llvm/test/DebugInfo/PowerPC/live-debug-vars-subreg-offset.ll
  llvm/test/DebugInfo/X86/dbg-declare-arg.ll
  llvm/test/DebugInfo/X86/dbg-value-of-spill-with-fp.ll
  llvm/test/DebugInfo/X86/dbg-value-when-spilt.ll
  llvm/test/DebugInfo/X86/fission-ranges.ll
  llvm/test/DebugInfo/X86/op_deref.ll
  llvm/test/DebugInfo/X86/parameters.ll
  llvm/test/DebugInfo/X86/pieces-4.ll
  llvm/test/DebugInfo/X86/pr34545.ll
  llvm/test/DebugInfo/X86/prolog-params.mir
  llvm/test/DebugInfo/X86/spill-indirect-nrvo.ll
  llvm/test/DebugInfo/X86/spill-nontrivial-param.ll
  llvm/test/DebugInfo/X86/spill-nospill.ll
  llvm/test/DebugInfo/X86/sret.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69178.231884.patch
Type: text/x-patch
Size: 63456 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191203/a2fc2db0/attachment-0001.bin>