[PATCH] D70758: [PowerPC][NFC] Rename record instructions to use _record suffix instead of o

Justin Hibbits via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 3 07:27:34 PST 2019


jhibbits added a comment.

I still hold pretty strongly that this change is a more negative impact than positive.  As shown in the tests, it's very easy to read the generated statements as "FOO-dot", and search for what 'foo.' actually is.  The only difficult part is the '*8' vs '*4', since you can't search for that, and need to remember to drop the number, which isn't difficult after the first time.

Searching the POWER ISA 3.0B reference, I see IBM using "period(.)", while the "EREF_RM" (NXP/Freescale Book-E reference) uses "dot suffix", with "record-form" only being used when describing the actual encoding.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70758/new/

https://reviews.llvm.org/D70758





More information about the llvm-commits mailing list