[PATCH] D70758: [PowerPC][NFC] Rename record instructions to use r suffix instead of o

Justin Hibbits via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 2 13:58:00 PST 2019


jhibbits requested changes to this revision.
jhibbits added a comment.

I second @nemanjai, the lowercase 'o' suffix stands out to me as a clear indicator of it being punctuation, not a letter in the instruction.  I would much rather see ANDIo than ANDIr, the 'r' just doesn't look right when reading over it.  My vote is to reject.  It looks like a lot of churn without much benefit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70758/new/

https://reviews.llvm.org/D70758





More information about the llvm-commits mailing list