[PATCH] D70758: [PowerPC][NFC] Rename record instructions to use r suffix instead of o

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai requested changes to this revision.
nemanjai added a subscriber: joerg.
nemanjai added a comment.
This revision now requires changes to proceed.

I am going to mark this as requiring changes until we can get more consensus on the direction. This is a very pervasive change that is completely subjective and as such should require agreement from more than two people that work on the target.

Personally, I am on the fence with a slight lean towards keeping the `o` convention we had before. While I understand that things like `ADDOo` may appear a bit ambiguous, I would say that `ANDIr` and `RLDICRr` is downright weird. To me, the fact that the mnemonic is all uppercase and the `o` that is a stand-in for the dot is pretty clear, but that may just be the fact that I am so familiar with the existing naming. Furthermore, the flag we set in the multiclasses is called `isDOT` and there is no clear relationship between this "dot" and the letter `r`. All that said, I will not block this if the majority is in agreement (or indifferent). But let's get some more eyes on this.

Perhaps @hfinkel, @jhibbits, @echristo or @joerg might have some input on this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70758/new/

https://reviews.llvm.org/D70758