[PATCH] D70461: [AIX] Emit TOC entries for ASM printing

[Jason Liu via Phabricator via llvm-commits]

jasonliu accepted this revision.
jasonliu added a comment.
This revision is now accepted and ready to land.

Minor nit that could be address while landing.
Otherwise LGTM.



================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1862
+PPCAIXAsmPrinter::getMCSymbolForTOCPseudoMO(const MachineOperand &MO) {
+  const GlobalObject *GO=nullptr;
+
----------------
nit: Add some spaces here.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1872
+  // eventually.
+  auto *GV = dyn_cast<const GlobalVariable>(GO);
+  if (GV) {
----------------
Could GV be const here? 


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1881
+  // declaration of a function, then XSym is an external referenced symbol.
+  // Hence we may need to explictly create a MCSectionXCOFF for it so we can
+  // return its symbol later.
----------------
... for it so **that** we...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70461/new/

https://reviews.llvm.org/D70461