[PATCH] D70461: [AIX] Emit TOC entries for ASM printing
David Tenty via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 27 13:14:56 PST 2019
daltenty marked 10 inline comments as done.
daltenty added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1765
+
+ // Handle external global variables later.
+ if (!GV->hasInitializer()) {
----------------
jasonliu wrote:
> "Handle ... later" sounds confusing for an early return.
> It's more like, we don't need to do anything for external global variables.
> And this early return could be just after "ValidateGV(GV);", I think we already set storage class for the symbol in getMCSymbolForTOCPseudoMO. Is that right?
>
Yes, that's correct. We end up covering this coincidentally.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70461/new/
https://reviews.llvm.org/D70461
More information about the llvm-commits
mailing list