[PATCH] D70651: [Power8] Add the MacroFusion support for Power8

[qshanz via Phabricator via llvm-commits]

steven.zhang marked 2 inline comments as done.
steven.zhang added a comment.

https://reviews.llvm.org/D70768 is created for the NFC patch.



================
Comment at: llvm/lib/Target/PowerPC/PPC.td:168
+def FeatureFusion : SubtargetFeature<"fusion", "HasFusion", "true",
+                                     "Target supports instruction fusion.">;
+def FeatureAddiLoadFusion : SubtargetFeature<"fuse-addi-load",
----------------
jsji wrote:
> No `.` for others, why we need one here? :)
It is typo.


================
Comment at: llvm/lib/Target/PowerPC/PPCMacroFusion.cpp:20
+using namespace llvm;
+namespace {
+
----------------
jsji wrote:
> Is it better to put this into PPC namespace instead of anonymous namespace?
As it is used internally and I don't want to pollute the PPC namespace.  Anonymous namespace is fine from what I think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70651/new/

https://reviews.llvm.org/D70651