[PATCH] D70651: [Power8] Add the MacroFusion support for Power8

[qshanz via Phabricator via llvm-commits]

steven.zhang marked an inline comment as done.
steven.zhang added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPC.td:255
+
+  list<SubtargetFeature> Power8InheritFeatureList =
+      !listconcat(Power7FeatureList, Power8SpecificFeatures);
----------------
jsji wrote:
> I like the idea of separating the inheritable feature and sub-target specific feature.
> However, I think this should be done in an NFC patch before this.
> 
> And it looks confusing to me about having `Power8SpecificFeatures` and `Power8OnlyFeature`, 
> are P8 specific feature supposed to be P8 only?
> 
> Maybe we should align with X86, name them: `P8InheritableFeatures` , `P*AdditionalFeatures` , `P*SpecificFeatures`/`P*OnlyFeatures`? 
Good point.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70651/new/

https://reviews.llvm.org/D70651