[PATCH] D70443: [AIX][XCOFF] Generate undefined symbol in symbol table for external function call

[Jason Liu via Phabricator via llvm-commits]

jasonliu marked 4 inline comments as done.
jasonliu added a comment.

Addressed post review comments in https://github.com/llvm/llvm-project/commit/7707d8aa9db8aa3814593f9c40cc707f306e3ae2



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5338
+          Context.getXCOFFSection(S->getName(), XCOFF::XMC_PR, XCOFF::XTY_ER,
+                                  XCOFF::C_EXT, SectionKind::getMetadata());
+      S->setContainingCsect(Sec);
----------------
hubert.reinterpretcast wrote:
> Does it make sense to check the linkage on the function? What if it is weak?
You are right. We would have a weak external referenced symbol in that case. 
We will also need to do more work for weak function in the future though, for example, emit ".weak .foo" and so on. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70443/new/

https://reviews.llvm.org/D70443