[PATCH] D70443: [AIX][XCOFF] Generate undefined symbol in symbol table for external function call
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 25 08:43:00 PST 2019
hubert.reinterpretcast added a comment.
Minor nits if the weak function case needs to be addressed anyway (probably at least a TODO).
================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:577
+
+ // Calculate undefined symbol's indices.
+ for (auto &Csect : UndefinedCsects) {
----------------
s/symbol's/symbols'/;
or
Calculate indices for undefined symbols.
================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5334
+ if (GV && GV->isDeclaration() && !S->hasContainingCsect()) {
+ // On AIX, undefined symbol need to associate with a MCSectionXCOFF to
+ // get the correct storage mapping class. In this case, XCOFF::XMC_PR.
----------------
Suggestion:
<ins>an </ins>undefined symbol need<ins>s</ins> to <ins>be </ins>associate<ins>d</ins> with
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70443/new/
https://reviews.llvm.org/D70443
More information about the llvm-commits
mailing list