[PATCH] D70601: Disallow DIExpressions with shift operators from being fragmented

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

> LGTM. It might be cleaner to replace the macros with helper functions which accept opcodes as vector<uint64_t> (using brace init on the caller side should be pretty readable).

+1

LGTM as well.

Please make a stack of patches for this one,  D70248 <https://reviews.llvm.org/D70248> and D61184 <https://reviews.llvm.org/D61184>, since it will be easier to review.  Eventually, when we land this, we will have the reminder noted here that the patches were connected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70601/new/

https://reviews.llvm.org/D70601