[PATCH] D70682: [scudo][standalone] Make tests work on Fuchsia

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/secondary.h:122
 
-  if (MaxFreeListSize && AlignmentHint < PageSize) {
+  if (!SCUDO_FUCHSIA && MaxFreeListSize && AlignmentHint < PageSize) {
     ScopedLock L(Mutex);
----------------
hctim wrote:
> I worry about adding ifdefs in core implementation files. Is it possibly a better idea to abstract the freelist away into a platform-specific implementation file? If so, you could also make this configurable at runtime...
So MaxFreeListSize is set to 0U in the Fuchsia config, which will make this go away, so the SCUDO_FUCHSIA is not needed.
I can change that to a COMPILER_CHECK.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70682/new/

https://reviews.llvm.org/D70682