[PATCH] D70682: [scudo][standalone] Make tests work on Fuchsia
Mitch Phillips via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 25 10:54:43 PST 2019
hctim added inline comments.
================
Comment at: compiler-rt/lib/scudo/standalone/secondary.h:122
- if (MaxFreeListSize && AlignmentHint < PageSize) {
+ if (!SCUDO_FUCHSIA && MaxFreeListSize && AlignmentHint < PageSize) {
ScopedLock L(Mutex);
----------------
I worry about adding ifdefs in core implementation files. Is it possibly a better idea to abstract the freelist away into a platform-specific implementation file? If so, you could also make this configurable at runtime...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70682/new/
https://reviews.llvm.org/D70682
More information about the llvm-commits
mailing list