[PATCH] D70590: [Examples] Add add_llvm_example_library macro and use it for IR example.

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 23 17:10:36 PST 2019


compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.

I think that rather than adding more wrapping macros, we should fix the structure.  We can mark the examples directory from `ALL` at the `add_subdirectory` level and only add the subdirectory when examples are enabled.  This avoids the need for the new macro.  I think that we want to move towards a more standard cmake build rather than a more specialized one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70590/new/

https://reviews.llvm.org/D70590





More information about the llvm-commits mailing list