[PATCH] D70590: [Examples] Exclude ExampleIRTransforms from ALL if examples are disabled.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 22 04:43:40 PST 2019


fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/examples/IRTransforms/CMakeLists.txt:7
 
+# Do not include examples in "all" target. Also excludes it from the install
+# list.
----------------
andwar wrote:
> [nit] Could you add a comment explaining `why` this is needed? Currently it says `what` is being done, but that's clear from the code. This could useful to our future selves.
Thanks for taking a look. I move the logic into a macro similar to `add_llvm_example`, which now takes care of respecting LLVM_BUILD_EXAMPLES and more.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70590/new/

https://reviews.llvm.org/D70590





More information about the llvm-commits mailing list